Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install: Actually honor kargs #172

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

cgwalters
Copy link
Collaborator

I think this got lost in a refactoring.

Closes: #163

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Any chance to (unit) test?

I think this got lost in a refactoring.

Closes: containers#163
Signed-off-by: Colin Walters <[email protected]>
@cgwalters cgwalters force-pushed the install-alongside-karg branch from 1f46011 to 167b9e4 Compare November 3, 2023 13:11
@cgwalters
Copy link
Collaborator Author

Yep, added a test

@cgwalters cgwalters enabled auto-merge November 3, 2023 13:12
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@cgwalters cgwalters merged commit daeb900 into containers:main Nov 3, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--karg option for install-to-filesystem is ignored?
2 participants